As I sip my evening tea, it's time for another #bevymergetrain :) It looks like the other maintainers have done a good job staying on top of the #opensource #rustlang #gamedev PRs this week: only 4 in the backlog of community-approved-but-not-merged right now. https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+label%3AS-Ready-For-Final-Review+-label%3AS-Controversial+-label%3AS-Blocked+-label%3AS-Adopt-Me+
Let's go through the list, explain why they're neat, and I'll share my reasoning for why they should (or shouldn't) be merged today :)
1. https://github.com/bevyengine/bevy/pull/11890
Adds double-ended arrows to gizmos. Gizmos are our "draw a quick and shitty thing on the screen for debug purposes" tool. Arrows are definitely handy, and I think I can see the value in double-ended ones for things like demarcating lengths. Sure, that's neat.
The linked tracking issue is a great collection of bite-sized improvements to them: very pleased with it! Code is sensible and small, and documented in an example. Great, merging.
2. https://github.com/bevyengine/bevy/pull/12769
Fixes a bug in the interaction of sprite anchors and sprite slicing (as might be used in frame-based 2D animation). Fix itself is good, although a regression test would have been nice.
The author couldn't think of a clean and reliable way to test this, and I couldn't either immediately, so we'll merge the fix for now. If you have better ideas, do open an issue or PR though with a test or three!
3. https://github.com/bevyengine/bevy/pull/12971
Another week, another "oh we forgot to reflect this type" PR. This time, `EntityHashSet`, Bevy's performance optimized hash set for `Entity` objects. Its hash map sibling has an implementation, but this one doesn't.
Good to clean up, and really solid help and guidance by SkiFire13 in the comments <3 Love to see it: they're consistently patient and knowledgeable. Merging.
4. https://github.com/bevyengine/bevy/pull/12980
Finally, a PR that only I have approved This PR fixes some lints detected on Rust's beta branch, via our fancy "periodically run CI on beta and file an issue if it fails" workflow.
All of these failures are real, if pedantic. This PR falls into the category of "trivial": it's easily verified by inspection, and has approximately zero user-facing impact. That means it gets the ready-for-final-review label with only one approval.
That said, I'll wait for a second review: this is only a few hours old, super easy to review, and has a moderate number of lines changed. There's no rush :) Maybe *you* want to try your hand at reviewing Bevy PRs for the first time?
Thanks for following along! I've been slowly ramping back into work mode as my partner recovers: Sixfold and I have a #bevy crate cooking that we think you'll enjoy! Looks like just another full day of writing docs first before release though ;)
@alice_i_cecile Such teasing !