Back

This is labelled X-Contentious, and with good reason. There are implications to consider, but no one thinks this is a *bad* direction and it's well isolated.

I really like how the API has evolved; this is much nicer. Reviews are high quality! Okay, code quality is good, and I like the strategy they used for implementation. Docs are inadequate though, and there are a couple of serious rough edges (no Res<T>?) that I want to polish before release. Requesting changes and adding to 0.15 milestone.

4. https://github.com/bevyengine/bevy/pull/13218

Oh wow. This is the "use Sebastien Aaltonen's ofset-allocator design to make rendering faster" PR. Those are some *impressive* performance gains. Multiple milliseconds reduced overhead on Bistro, a high-end but not unreasonable test scene.

This is beyond my rendering skill level, although the code quality and descriptions are great (thank pcwalton). The author added this to the 0.15 milestone: I'm going to ask rendering opinions on what to do here.

5. https://github.com/bevyengine/bevy/pull/13277

A straightforward enough change to how we're tracking information about the order in which we render entities. Rather than adding components to the entities in the render world, keep a map of them in various resources.

There's a modest performance gain, but the real impetus is in simplifying and reducing the render world's use of the ECS. The current extraction strategy used for pipelined rendering is complex, fragile and costly. Painful for new ECS features!

The PR itself looks solid: simple, well-made, widely approved by folks with relevant expertise. Let's merge it :)

6. https://github.com/bevyengine/bevy/pull/13380

A math bug! I'm so so glad that we've fostered a little herd of mathematicians in Bevy now: very handy to have them on hand when we need to nerdsnipe them somehow.

In this case, we weren't recomputing normals correctly when rescaling meshes, leading to weird artifacts. Some good discussion in the comments about correctness but this is resolved now.

Looks good and there's a regression test. Merging.

7. https://github.com/bevyengine/bevy/pull/13415

bevy_assets usability improvements! Very pleased to see work here pick up in 0.14: there was a long period where we were "waiting for the rewrite" and it took folks a while to get their feet wet with the new code base.

This PR integrates the "load asset with these settings" API into our "please don't get fancy with async" API. Great, this should exist.

There's a nice follow-up issue for making the API more cohesive with the builder pattern but that can wait. Merge!

8. https://github.com/bevyengine/bevy/pull/13417

Speaking of PRs that are useful but could benefit from future work: a genuinely nice API for sorting queries.

Go look at the examples in the PR! They're way nicer than I thought possible. Great application of the esoteric query transmutes here.

All sorts of fancy caching can and probably should be done in the future, but for now, let's get this to users. Very useful as is. Merging.

9. https://github.com/bevyengine/bevy/pull/13430

Today, our pet mathematicians bring us such gems as "Now, convert a point from the fundamental tetrahedron into barycentric coordinates by taking the four successive differences of coordinates; note that these telescope to sum to 1, and this transformation is linear, hence preserves the probability density, since the latter comes from the Lebesgue measure."

Truly, arcane incantations (thankfully my training has prepared me) but remarkably clear to the experts.

Sampling the faces and interior of triangular prisms is useful enough as an operation, and this is well done. Very nice documentation and code quality: I would be happy to see this used as a reference implementation of the algorithm.

Merging!

10. https://github.com/bevyengine/bevy/pull/13438

One of the constant chores of large projects is maintaining consistency across it. In this case, we would use "segments" to describe the number of sections used to draw things like circles in a gizmos context, and "resolution" in a rendering context. As the original issue says, we should use the rendering convention to confuse people less.

Good refactor: it's nice to see associated methods and constants cleaned up too. Merging. Thank goodness forbreaking changes.

11. https://github.com/bevyengine/bevy/pull/13449

Lava burning bright with the fire of a thousand suns! Nah, actually that's just a bug. Whoops! We fixed a bug in our rendering code last week, but one of the examples needs to be retuned to stop working around it.

I checked this PR out locally using the `gh` CLI tool earlier today to validate the change. Looks broken on `main`, and much more reasonable on this branch. Weird diff though, thanks Github. Merging.

@MaeDay Fixed, thanks!